Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts(visual-regression): show target filename #48444

Merged
merged 4 commits into from Apr 15, 2024

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Apr 14, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

解决 #48443 (comment) 提到的对比原图的名称问题

📝 Changelog

Language Changelog
🇺🇸 English -----
🇨🇳 Chinese -----

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 14, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 14, 2024

👁 Visual Regression Report for PR #48444 Failed ❌

🎯 Target branch: master (daba39b)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
steps-label-placement.compact.png steps-label-placement.compact.png steps-label-placement.compact.css-var.png steps-label-placement.compact.css-var.png
steps-label-placement.dark.png steps-label-placement.dark.png steps-label-placement.dark.css-var.png steps-label-placement.dark.css-var.png
steps-label-placement.default.png steps-label-placement.default.png steps-label-placement.default.css-var.png steps-label-placement.default.css-var.png
steps-progress-debug.dark.png steps-progress-debug.dark.png steps-progress-debug.dark.css-var.png steps-progress-debug.dark.css-var.png
steps-progress.compact.png steps-progress.compact.png steps-progress.compact.css-var.png steps-progress.compact.css-var.png

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 14, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.49 KB
./dist/antd-with-locales.min.js 383.61 KB

Copy link

codesandbox-ci bot commented Apr 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (89eba93) to head (12a7686).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48444   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12875     12875           
  Branches      3366      3366           
=========================================
  Hits         12875     12875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagusX vagusX force-pushed the scripts/better-show-target-filename branch 2 times, most recently from 1093ebc to b9fcb8d Compare April 14, 2024 14:21
@vagusX vagusX changed the title scripts(visual-regression): show target filename WIP: scripts(visual-regression): show target filename Apr 15, 2024
@vagusX vagusX force-pushed the scripts/better-show-target-filename branch from 594ad64 to 12a7686 Compare April 15, 2024 05:45
@vagusX vagusX requested a review from zombieJ April 15, 2024 06:00
@vagusX vagusX changed the title WIP: scripts(visual-regression): show target filename scripts(visual-regression): show target filename Apr 15, 2024
@afc163 afc163 merged commit b42ffe6 into master Apr 15, 2024
106 of 107 checks passed
@afc163 afc163 deleted the scripts/better-show-target-filename branch April 15, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants