Feat/droprdown accessibility #48499
Open
Feat/droprdown accessibility #48499
+46
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👁 Visual Regression Report for PR #48499 Failed ❌
Check Full Report for details |
|
|
|
KirilCycle
commented
Apr 16, 2024
| @@ -43,7 +43,8 @@ export type DropdownArrowOptions = { | |||
| }; | |||
|
|
|||
| export interface DropdownProps { | |||
| menu?: MenuProps; | |||
| menu: MenuProps; | |||
| menuLabel?: string; | |||
There was a problem hiding this comment.
Can i make this prop as required ? Each menu must have unique label, as i use it to bound menu btn and menu itself
components/dropdown/dropdown.tsx
Outdated
| @@ -238,7 +263,9 @@ const Dropdown: CompoundedComponent = (props) => { | |||
|
|
|||
| let overlayNode: React.ReactNode; | |||
| if (menu?.items) { | |||
| overlayNode = <Menu {...menu} />; | |||
| overlayNode = ( | |||
| <Menu ref={menuRef} aria-labelledby={`${menuLabel}-button`} id={`${menuLabel}-menu`} {...menu} /> | |||
components/dropdown/dropdown.tsx
Outdated
| const handleKeyPress = (e: KeyboardEvent) => { | ||
| if (e.key === 'Enter' || e.code === 'Space') { | ||
| targetElement.removeEventListener('keypress', handleKeyPress); | ||
| onOpenChange?.(true, { source: 'menu' }) |
There was a problem hiding this comment.
Is better to use onInnerOpenChange then this hardcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fix #48132
📝 Changelog
☑️ Self-Check before Merge