Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clearedColor should be changed when initial value is undefined #48584

Merged
merged 1 commit into from Apr 23, 2024

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Apr 22, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48577

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ColorPicker that cleared icon should change when initial value is undefined.
🇨🇳 Chinese 修复 ColorPicker 在初始未受控时清除图标不会改变的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

👁 Visual Regression Report for PR #48584 Passed ✅

🎯 Target branch: master (50d8201)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Preview is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 337.02 KB (-4 B 🔽)
./dist/antd-with-locales.min.js 384.46 KB (-34 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (50d8201) to head (1f49e3e).

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48584    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          745       745            
  Lines        13603     12946   -657     
  Branches      3628      3382   -246     
==========================================
- Hits         13603     12946   -657     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit ce176a8 into master Apr 23, 2024
109 checks passed
@MadCcc MadCcc deleted the fix/color-picker-default-undefined branch April 23, 2024 02:02
@vagusX vagusX mentioned this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColorPicker被Form.Item包裹,value不生效
4 participants