Fix Tooltip on disabled button #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
afc163
commented
Feb 14, 2017
•
afc163
commented
- ref mouseleave don't trigger on disabled inputs and button react-component/tooltip#18
- Close Tooltip和disabled Button一起使用，mouseout的时候Tooltip没有隐藏 #1816
- Close Tooltip acts weird on the disabled button inside the table row. #4346
- Close Tooltip 和 Button(disabled) 混用BUG #2381
- Close Tooltip acts weird on the disabled button inside the table row. #4346
- Close popover/tooltip chilren为button disabled 时 hoverout 失效 #4602
- Close Button禁用后Tooltip不会正常消失。 #2097
|
@afc163, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @waywardmonkeys and @jljsj33 to be potential reviewers. |
afc163
force-pushed
the
fix-tooltip-on-disabled-button
branch
3 times, most recently
from
f47ead2
to
6e1a659
Compare
|
Changes Unknown when pulling 6e1a659 on fix-tooltip-on-disabled-button into ** on master**. |
|
覆盖率为啥会下降？@yesmeck |
|
@ @ 不是很清楚。。因为现在的覆盖率本来就是有点不准的，是按 Babel 转换后的代码计算的，而不是按 TypeScript 计算的。 |
afc163
force-pushed
the
fix-tooltip-on-disabled-button
branch
from
707df13
to
449a6a6
Compare
|
Changes Unknown when pulling 449a6a6 on fix-tooltip-on-disabled-button into ** on master**. |
|
变成 unknown 了... |
benjycui
reviewed
Feb 16, 2017
| const button = wrapper.find('button').at(0); | ||
| button.simulate('mouseenter'); | ||
| expect(onVisibleChange).not.toHaveBeenCalled(); | ||
| expect(wrapper.ref('tooltip').prop('visible')).toBe(false); |
There was a problem hiding this comment.
According to me, Tooltip's visible should be true and onVisibleChange should be called when mouse enter button, right?
benjycui
reviewed
Feb 16, 2017
| expect(wrapper.ref('tooltip').prop('visible')).toBe(false); | ||
|
|
||
| button.simulate('mouseleave'); | ||
| expect(onVisibleChange).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
This should be called, too.
afc163
force-pushed
the
fix-tooltip-on-disabled-button
branch
from
774858a
to
adc2068
Compare
1 task
1 task
Closed
1 task
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.