Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert locked React version #48674

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

chore: revert locked React version #48674

wants to merge 7 commits into from

Conversation

li-jia-nan
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English revert: revert locked React version
🇨🇳 Chinese revert: revert locked React version

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 28, 2024

👁 Visual Regression Report for PR #48674 Passed ✅

🎯 Target branch: master (470e8a8)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 28, 2024

Preview is ready

Copy link

socket-security bot commented Apr 28, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

Copy link

socket-security bot commented Apr 28, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@li-jia-nan
Copy link
Member Author

li-jia-nan commented Apr 28, 2024

@SocketSecurity ignore npm/fsevents@1.2.13

Copy link
Contributor

github-actions bot commented Apr 28, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 337.63 KB
./dist/antd-with-locales.min.js 385.62 KB

Copy link

codesandbox-ci bot commented Apr 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (470e8a8) to head (15b9a3c).

❗ Current head 15b9a3c differs from pull request most recent head 8610f06. Consider uploading reports for the commit 8610f06 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48674   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        12994     12994           
  Branches      3411      3411           
=========================================
  Hits         12994     12994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan changed the title revert: revert locked React version chore: revert locked React version Apr 28, 2024
@li-jia-nan li-jia-nan changed the title chore: revert locked React version chore: [WIP] revert locked React version Apr 28, 2024
@li-jia-nan li-jia-nan changed the title chore: [WIP] revert locked React version chore: revert locked React version Apr 29, 2024
@li-jia-nan li-jia-nan marked this pull request as draft April 29, 2024 00:27
@afc163
Copy link
Member

afc163 commented May 4, 2024

还差什么?

@li-jia-nan
Copy link
Member Author

还差什么?

闲夕大佬说 findDOMNode is deprecated 的警告别忽略,很多用例就是测这个的

这样的话 React 版本就要锁在 18.2.0 了,所以我不确定这个 PR 能不能合

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants