Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(zip builds): skip fork branch #48783

Merged
merged 1 commit into from
May 6, 2024
Merged

ci(zip builds): skip fork branch #48783

merged 1 commit into from
May 6, 2024

Conversation

thinkasany
Copy link
Contributor

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

ci在步骤 zip builds 时执行的脚本需要用到ALI_OSS_AK_ID,node scripts/visual-regression/upload.js.

希望能在fork分支跳过这个ci,虽然目前通过github.ref == 'refs/heads/master' 指定了master分支,但是可能有很多同学在fork的master上贡献,或者会有同步master和上游一致的习惯。
image

image

image

📝 Changelog

Language Changelog
🇺🇸 English ci(zip builds): skip fork branch
🇨🇳 Chinese ci(zip builds): 跳过 fork 分支

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 6, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 6, 2024

👁 Visual Regression Report for PR #48783 Passed ✅

🎯 Target branch: master (8b1f79c)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented May 6, 2024

Hi @thinkasany. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@afc163 afc163 merged commit 06d78e6 into ant-design:master May 6, 2024
22 of 35 checks passed
Copy link

codesandbox-ci bot commented May 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@thinkasany thinkasany deleted the ci branch June 7, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants