Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: progress support size object #48805

Merged
merged 10 commits into from
May 9, 2024
Merged

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented May 7, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English progress support size object
🇨🇳 Chinese 进度条支持 size 对象

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 7, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 7, 2024

👁 Visual Regression Report for PR #48805 Passed ✅

🎯 Target branch: feature (00c7705)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented May 7, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 337.56 KB (-87 B 🔽)
./dist/antd-with-locales.min.js 385.59 KB (+144 B 🔺)

Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

components/progress/utils.ts Outdated Show resolved Hide resolved
@crazyair crazyair requested review from afc163 and zombieJ May 7, 2024 09:13
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (00c7705) to head (33e28dc).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48805   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        12994     12997    +3     
  Branches      3411      3413    +2     
=========================================
+ Hits         12994     12997    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazyair
Copy link
Member Author

crazyair commented May 7, 2024

@afc163 优化了下方法,不过还得加 as [number, number] 因为 size 有个 string 类型,但是这个方法确是 number 类型

afc163
afc163 previously approved these changes May 8, 2024
Signed-off-by: afc163 <afc163@gmail.com>
afc163
afc163 previously approved these changes May 8, 2024
@afc163 afc163 merged commit 1da6d23 into feature May 9, 2024
103 checks passed
@afc163 afc163 deleted the progress-support-size-object branch May 9, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants