Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: image component adding destroyOnClose #48827

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

wanpan11
Copy link
Contributor

@wanpan11 wanpan11 commented May 8, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48818

💡 Background and solution

补充文档

📝 Changelog

Language Changelog
🇺🇸 English image component adding destroyOnClose
🇨🇳 Chinese image 组件文档添加 destroyOnClose

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 8, 2024

👁 Visual Regression Report for PR #48827 Passed ✅

🎯 Target branch: master (4384984)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented May 8, 2024

Preview is ready

Copy link

codesandbox-ci bot commented May 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Wxh16144
Copy link
Member

Wxh16144 commented May 8, 2024

可以顺手把 demo 也修复一下 (加上这个属性)

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4384984) to head (2d45b9f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48827   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        12996     12996           
  Branches      3412      3412           
=========================================
  Hits         12996     12996           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit e2d7e68 into ant-design:master May 8, 2024
61 checks passed
@wanpan11 wanpan11 deleted the image branch May 8, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

图片插件-视频播放时,关闭弹窗,声音仍然在播放
4 participants