fix: fix Button findDOMNode error #48830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #48830 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
wanpan11
force-pushed
the
button-findDOMNode
branch
from
818db7b
to
1676c95
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48830 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 746 746
Lines 12994 12994
Branches 3411 3411
=========================================
Hits 12994 12994 ☔ View full report in Codecov by Sentry. |
|
加个测试用例吧 |
zombieJ
reviewed
May 9, 2024
afc163
reviewed
May 9, 2024
li-jia-nan
reviewed
May 9, 2024
Co-authored-by: lijianan <574980606@qq.com> Signed-off-by: Wanpan <wanpan96@163.com>
afc163
reviewed
May 9, 2024
|
现在可以了
|
zombieJ
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
fix #48809
💡 Background and solution
Button 组件点击时 WaveEffect 组件没有使用 setNodeRef
📝 Changelog
☑️ Self-Check before Merge