Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Drawer Spin className #48857

Merged
merged 2 commits into from
May 10, 2024
Merged

fix: add Drawer Spin className #48857

merged 2 commits into from
May 10, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented May 10, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: add Spin className
🇨🇳 Chinese 给 Drawer 的内部组件 Spin 添加 className,防止内部 Spin 样式覆盖用户传入的 Spin 样式

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 10, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 10, 2024

👁 Visual Regression Report for PR #48857 Passed ✅

🎯 Target branch: master (6da1ad1)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented May 10, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 337.73 KB (+2 B 🔺)
./dist/antd-with-locales.min.js 385.46 KB (-85 B 🔽)

@afc163
Copy link
Member

afc163 commented May 10, 2024

Drawer 的 Spin 改成包裹是不是会更好一点?#48858

Copy link

codesandbox-ci bot commented May 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@li-jia-nan
Copy link
Member Author

Drawer 的 Spin 改成包裹是不是会更好一点?#48858

等 Preview 跑过了看看效果

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c3cf0de) to head (e17279f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48857   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        12994     12994           
  Branches      3411      3411           
=========================================
  Hits         12994     12994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan changed the title fix: add Spin className fix: add Drawer Spin className May 10, 2024
@afc163 afc163 merged commit 32b89e6 into master May 10, 2024
107 checks passed
@afc163 afc163 deleted the add-cls branch May 10, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants