Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix float-button findDOMNode error #48865

Merged
merged 1 commit into from
May 10, 2024

Conversation

wanpan11
Copy link
Contributor

@wanpan11 wanpan11 commented May 10, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

float-button.backTop findDOMNode error

image

📝 Changelog

Language Changelog
🇺🇸 English fix float-button.backTop findDOMNode error
🇨🇳 Chinese 修复 float-button.backTop findDOMNode 报错

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 10, 2024

👁 Visual Regression Report for PR #48865 Passed ✅

🎯 Target branch: master (1f39811)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented May 10, 2024

Preview is ready

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@li-jia-nan
Copy link
Member

是不是用到 CSSMotion 动画库的组件都会有报错

@wanpan11
Copy link
Contributor Author

是不是用到 CSSMotion 动画库的组件都会有报错

用了 CSSMotion 组件 但是没用调用 setRef 的就会报错,有些组件我看是调用了

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6da1ad1) to head (b18d26a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48865   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        12994     12994           
  Branches      3411      3411           
=========================================
  Hits         12994     12994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit c9f7f5d into ant-design:master May 10, 2024
69 checks passed
@wanpan11 wanpan11 deleted the floatButton-findDOMNode branch May 10, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FloatButton 最新版本 (5.12.1) 依然报console warning
3 participants