Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): support pauseOnHover props #49024

Merged
merged 2 commits into from
May 27, 2024

Conversation

yociduo
Copy link
Contributor

@yociduo yociduo commented May 22, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48985

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Notification support pauseOnHover prop
🇨🇳 Chinese Notification 支持 pauseOnHover 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 22, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 22, 2024

👁 Visual Regression Report for PR #49024 Failed ❌

🎯 Target branch: feature (2b86be4)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
date-picker-needConfirm.compact.png date-picker-needConfirm.compact.png date-picker-needConfirm.compact.png date-picker-needConfirm.compact.png
date-picker-needConfirm.compact.png date-picker-needConfirm.compact.png date-picker-needConfirm.compact.css-var.png date-picker-needConfirm.compact.css-var.png
date-picker-needConfirm.dark.png date-picker-needConfirm.dark.png date-picker-needConfirm.dark.png date-picker-needConfirm.dark.png
date-picker-needConfirm.dark.png date-picker-needConfirm.dark.png date-picker-needConfirm.dark.css-var.png date-picker-needConfirm.dark.css-var.png
date-picker-needConfirm.default.png date-picker-needConfirm.default.png date-picker-needConfirm.default.png date-picker-needConfirm.default.png
date-picker-needConfirm.default.png date-picker-needConfirm.default.png date-picker-needConfirm.default.css-var.png date-picker-needConfirm.default.css-var.png
notification-show-with-progress.compact.png notification-show-with-progress.compact.png notification-show-with-progress.compact.png notification-show-with-progress.compact.png
notification-show-with-progress.compact.png notification-show-with-progress.compact.png notification-show-with-progress.compact.css-var.png notification-show-with-progress.compact.css-var.png
notification-show-with-progress.dark.png notification-show-with-progress.dark.png notification-show-with-progress.dark.png notification-show-with-progress.dark.png
notification-show-with-progress.dark.png notification-show-with-progress.dark.png notification-show-with-progress.dark.css-var.png notification-show-with-progress.dark.css-var.png

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link

codesandbox-ci bot commented May 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@afc163 afc163 closed this May 23, 2024
@afc163 afc163 reopened this May 23, 2024
Copy link

socket-security bot commented May 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-notification@5.6.0 environment 0 88.3 kB afc163

🚮 Removed packages: npm/rc-notification@5.5.0

View full report↗︎

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fa0c473) to head (cfb755b).
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #49024   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        12996     12996           
  Branches      3417      3417           
=========================================
  Hits         12996     12996           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yociduo yociduo marked this pull request as draft May 23, 2024 07:51
@yociduo yociduo marked this pull request as ready for review May 23, 2024 11:31
@afc163 afc163 merged commit 1a250ce into ant-design:feature May 27, 2024
60 of 61 checks passed
@PeachScript PeachScript mentioned this pull request Jun 3, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants