Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale ca_ES (Catalan) #4929

Merged
merged 2 commits into from
Feb 19, 2017
Merged

Add locale ca_ES (Catalan) #4929

merged 2 commits into from
Feb 19, 2017

Conversation

aaronplanell
Copy link
Contributor

Hello,

I added the local for ca_ES (Catalan). Therefore, this fork only have four new files:

components/calendar/locale/ca_ES.tsx
components/date-picker/locale/ca_ES.tsx
components/locale-provider/ca_ES.tsx
components/time-picker/locale/ca_ES.tsx

And a modified file:

components/locale-provider/__tests__/index.test.js

Previously to this fork, I updated to other projects:

Finally, I run:

antd-tools run ts-lint
antd-tools run compile

Everything it's OK. Waiting for your fork 馃槃

@mention-bot
Copy link

@aaronplanell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163 and @corneyl to be potential reviewers.

import Calendar from '../calendar/locale/ca_ES';

export default {
locale: 'en',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be es?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry it's ca.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I correct it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @corneyl ! I made all those changes three times, hehehe.

@aaronplanell
Copy link
Contributor Author

For your information, previously, I had two discarded PR: 4927 and 4928.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 82.483% when pulling 22e5e9b on aaronplanell:feature-2.8 into 63476d0 on ant-design:feature-2.8.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 82.483% when pulling ff91200 on aaronplanell:feature-2.8 into 63476d0 on ant-design:feature-2.8.

@aaronplanell
Copy link
Contributor Author

Well, finally I think that all have worked 馃槃 . I suppose that this change will be available in the next release (2.8), is that correct?

Thanks a lot for your patience, especially to @afc163 , @yesmeck, benjycui and @corneyl 馃憤

@afc163 afc163 merged commit 05fd5a6 into ant-design:feature-2.8 Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants