Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor ink in fixed #4960

Merged
merged 2 commits into from
Feb 21, 2017
Merged

Anchor ink in fixed #4960

merged 2 commits into from
Feb 21, 2017

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Feb 20, 2017

@mention-bot
Copy link

@RaoHai, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @benjycui and @visvadw to be potential reviewers.

@RaoHai RaoHai changed the base branch from feature-2.8 to master February 20, 2017 08:05
@RaoHai RaoHai changed the base branch from master to feature-2.8 February 20, 2017 08:05
 + close ant-design#4930
 + add `inkInFixed` props to show ink-balls in fixed mode.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.309% when pulling 84cd8dc on RaoHai:AnchorInkInFixed into 18e554f on ant-design:feature-2.8.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.309% when pulling 84cd8dc on RaoHai:AnchorInkInFixed into 18e554f on ant-design:feature-2.8.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.309% when pulling 84cd8dc on RaoHai:AnchorInkInFixed into 18e554f on ant-design:feature-2.8.

@@ -20,6 +20,8 @@ For displaying anchor hyperlinks on page and jumping between them.
| offsetTop | Pixels to offset from top when calculating position of scroll | number | 0 |
| offsetBottom | Pixels to offset from bottom when calculating position of scroll | number | - |
| bounds | Bounding distance of anchor area | number | 5(px) |
| affix | Fixed mode of Anchor | boolean | false |
| inkInFixed | Whether show ink-balls in Fixed mode | boolean | false |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about showInk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showInk seems telling users that they could hide ink in all modes when set it false..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showInkInFixed

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.309% when pulling 640378b on RaoHai:AnchorInkInFixed into 18e554f on ant-design:feature-2.8.

@afc163 afc163 merged commit 36fd55c into ant-design:feature-2.8 Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants