Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix safari language check #5245

Merged
merged 1 commit into from
Mar 10, 2017
Merged

chore: fix safari language check #5245

merged 1 commit into from
Mar 10, 2017

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Mar 9, 2017

sad story..
safari navigator.language === 'zh-cn'

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you propose PR to correct branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@mention-bot
Copy link

@paranoidjk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @afc163 and @ddcat1115 to be potential reviewers.

@codecov
Copy link

codecov bot commented Mar 9, 2017

Codecov Report

Merging #5245 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5245   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files         161      161           
  Lines        1641     1641           
  Branches      559      559           
=======================================
  Hits         1359     1359           
  Misses        282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b54ad...7a6055f. Read the comment docs.

@paranoidjk paranoidjk changed the title chore: fix safari language check [WIP] chore: fix safari language check Mar 9, 2017
@paranoidjk paranoidjk changed the title [WIP] chore: fix safari language check chore: fix safari language check Mar 9, 2017
@benjycui benjycui merged commit c8fdf3e into master Mar 10, 2017
@benjycui benjycui deleted the fix/site-language branch March 10, 2017 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants