Filter Icon of Table #5293
Merged
Filter Icon of Table #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<Table columns={[{ filtered: true }]} /> |
RaoHai
force-pushed
the
customFilterIcon
branch
from
a070a4d
to
1597b99
Compare
RaoHai
force-pushed
the
customFilterIcon
branch
from
1597b99
to
788e585
Compare
|
done |
Codecov Report
@@ Coverage Diff @@
## feature-2.9 #5293 +/- ##
===============================================
+ Coverage 86.11% 86.12% +0.01%
===============================================
Files 174 174
Lines 4444 4448 +4
Branches 1288 1289 +1
===============================================
+ Hits 3827 3831 +4
Misses 617 617
Continue to review full report at Codecov.
|
afc163
reviewed
Mar 14, 2017
| @@ -43,6 +43,7 @@ class App extends React.Component { | |||
| filterDropdownVisible: false, | |||
| data, | |||
| searchText: '', | |||
| isFiltered: false, | |||
afc163
reviewed
Mar 14, 2017
components/table/index.zh-CN.md
Outdated
| @@ -94,6 +94,7 @@ const columns = [{ | |||
| | filterDropdownVisible | 用于控制自定义筛选菜单是否可见 | boolean | - | | |||
| | onFilterDropdownVisibleChange | 自定义筛选菜单可见变化时调用 | function(visible) {} | - | | |||
| | filteredValue | 筛选的受控属性，外界可用此控制列的筛选状态，值为已筛选的 value 数组 | string[] | - | | |||
| | filtered | 标识数据是否经过过滤 | boolean | false | | |||
afc163
reviewed
Mar 14, 2017
components/table/filterDropdown.tsx
Outdated
| @@ -209,7 +210,7 @@ export default class FilterMenu extends React.Component<FilterMenuProps, any> { | |||
| </FilterDropdownMenuWrapper> | |||
| ); | |||
|
|
|||
| const dropdownSelectedClass = (this.props.selectedKeys.length > 0) | |||
| const dropdownSelectedClass = (this.props.selectedKeys.length > 0 || this.props.filtered) | |||
|
想了下，不如把 |
|
rebase |
+ close ant-design#5287 + add `isFiltered` props for mark dataSource is filterd + improve CustomFilter Demo
RaoHai
force-pushed
the
customFilterIcon
branch
from
8909b1c
to
398284d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isFilteredprops for mark dataSource is filterd