Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SK Localization #5304

Merged
merged 1 commit into from
Mar 24, 2017
Merged

SK Localization #5304

merged 1 commit into from
Mar 24, 2017

Conversation

Kamahl19
Copy link
Contributor

Hi, here is the SK localization. Thanks!

@mention-bot
Copy link

@Kamahl19, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @minsungryu and @corneyl to be potential reviewers.

@benjycui
Copy link
Contributor

CI failed..

@benjycui
Copy link
Contributor

benjycui commented Mar 15, 2017

Make sure that you had added locale to dependencies:

Module not found: Error: Cannot resolve module 'rc-pagination/lib/locale/sk_SK'

@benjycui benjycui changed the title SK Localization [WIP] SK Localization Mar 15, 2017
@minsungryu
Copy link
Contributor

rc-pagination#64(react-component/pagination#64) and rc-calender#226(react-component/calendar#226) is waiting to be merged.

@Kamahl19
Copy link
Contributor Author

@benjycui Hi, both pagination and calendar translation have been merged so it should work fine now.

@benjycui benjycui changed the title [WIP] SK Localization SK Localization Mar 15, 2017
@benjycui
Copy link
Contributor

benjycui commented Mar 15, 2017

Actually.. rc-calendar need updating..

@Kamahl19
Copy link
Contributor Author

@benjycui Hi, I see you updated calendar to 7.7.0 already.

@afc163
Copy link
Member

afc163 commented Mar 18, 2017

Dependencies of antd should be updated.

@afc163
Copy link
Member

afc163 commented Mar 23, 2017

@Kamahl19

@Kamahl19
Copy link
Contributor Author

@afc163 should i just update rc-calendar version in package.json?

@afc163
Copy link
Member

afc163 commented Mar 23, 2017

Yes, but I already updated it in feature-2.9, I think you just need to rebase it.

@Kamahl19
Copy link
Contributor Author

@afc163 Thanks, I just did that

@codecov
Copy link

codecov bot commented Mar 23, 2017

Codecov Report

Merging #5304 into feature-2.9 will increase coverage by 0.04%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           feature-2.9    #5304      +/-   ##
===============================================
+ Coverage        86.01%   86.06%   +0.04%     
===============================================
  Files              166      170       +4     
  Lines             4412     4427      +15     
  Branches          1280     1283       +3     
===============================================
+ Hits              3795     3810      +15     
  Misses             617      617
Impacted Files Coverage Δ
components/locale-provider/sk_SK.tsx 100% <100%> (ø)
components/calendar/locale/sk_SK.tsx 100% <100%> (ø)
components/time-picker/locale/sk_SK.tsx 100% <100%> (ø)
components/date-picker/locale/sk_SK.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0b9ad...3827bd0. Read the comment docs.

@benjycui benjycui merged commit 82b516c into ant-design:feature-2.9 Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants