-
-
Notifications
You must be signed in to change notification settings - Fork 47.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SK Localization #5304
SK Localization #5304
Conversation
@Kamahl19, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @minsungryu and @corneyl to be potential reviewers. |
CI failed.. |
Make sure that you had added locale to dependencies: Module not found: Error: Cannot resolve module 'rc-pagination/lib/locale/sk_SK' |
rc-pagination#64(react-component/pagination#64) and rc-calender#226(react-component/calendar#226) is waiting to be merged. |
@benjycui Hi, both pagination and calendar translation have been merged so it should work fine now. |
Actually.. rc-calendar need updating.. |
@benjycui Hi, I see you updated calendar to 7.7.0 already. |
Dependencies of antd should be updated. |
@afc163 should i just update rc-calendar version in package.json? |
Yes, but I already updated it in |
33b7ae5
to
3827bd0
Compare
@afc163 Thanks, I just did that |
Codecov Report
@@ Coverage Diff @@
## feature-2.9 #5304 +/- ##
===============================================
+ Coverage 86.01% 86.06% +0.04%
===============================================
Files 166 170 +4
Lines 4412 4427 +15
Branches 1280 1283 +3
===============================================
+ Hits 3795 3810 +15
Misses 617 617
Continue to review full report at Codecov.
|
Hi, here is the SK localization. Thanks!