Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added card header style mixins #5354

Merged
merged 2 commits into from
Mar 17, 2017
Merged

added card header style mixins #5354

merged 2 commits into from
Mar 17, 2017

Conversation

kossel
Copy link
Contributor

@kossel kossel commented Mar 17, 2017

Less mixin for card header style

@mention-bot
Copy link

@kossel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @simaQ and @ddcat1115 to be potential reviewers.

@codecov
Copy link

codecov bot commented Mar 17, 2017 •
edited
Loading

Codecov Report

Merging #5354 into feature-2.9 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           feature-2.9    #5354   +/-   ##
============================================
  Coverage        82.59%   82.59%           
============================================
  Files              162      162           
  Lines             1620     1620           
  Branches           550      550           
============================================
  Hits              1338     1338           
  Misses             282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4382d4e...eace465. Read the comment docs.

benjycui
benjycui reviewed Mar 17, 2017
View reviewed changes
components/style/themes/default.less

// Card
// ---
@card-head-height: 48px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

head => header ?

Copy link
Contributor Author

@kossel kossel Mar 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the current class uses 'head' as name, I just want to make it consistent, or should I change to header?

https://github.com/ant-design/ant-design/blob/feature-2.9/components/card/style/index.less#L22

afc163
afc163 reviewed Mar 17, 2017
View reviewed changes
components/card/style/index.less Outdated
@@ -32,7 +33,7 @@
width: 100%;
overflow: hidden;
white-space: nowrap;
color: @heading-color;
color: @card-head-bgcolor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be @card-head-color?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops you are right, I will fix that

afc163
afc163 reviewed Mar 17, 2017
View reviewed changes
components/style/themes/default.less Outdated
// ---
@card-head-height: 48px;
@card-head-color: @heading-color;
@card-head-bgcolor: @component-background;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@card-head-background

@kossel
Copy link
Contributor Author

kossel commented Mar 17, 2017

Fixed

@afc163 afc163 merged commit 621f44e into ant-design:feature-2.9 Mar 17, 2017
@afc163
Copy link
Member

afc163 commented Mar 17, 2017 •
edited
Loading

close #5351

kossel added a commit to kossel/ant-design that referenced this pull request Mar 17, 2017
@kossel
Merge pull request #1 from ant-design/feature-2.9
5d3ebf2 
added card header style mixins (ant-design#5354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@benjycui benjycui benjycui left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kossel @mention-bot @afc163 @benjycui