Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix localeprovider on upload component #5388

Merged
merged 1 commit into from
Mar 20, 2017
Merged

fix localeprovider on upload component #5388

merged 1 commit into from
Mar 20, 2017

Conversation

natergj
Copy link
Contributor

@natergj natergj commented Mar 19, 2017

LocaleProvider translations were not being applied to Upload component. The PR adds context definition to Upload component so context provided by LocaleProvider is available.

@mention-bot
Copy link

@natergj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui and @afc163 to be potential reviewers.

@benjycui
Copy link
Contributor

Should be refactored with injectLocale, see: #5103

@benjycui benjycui closed this Mar 20, 2017
@benjycui benjycui self-assigned this Mar 20, 2017
@benjycui benjycui reopened this Mar 20, 2017
@codecov
Copy link

codecov bot commented Mar 20, 2017

Codecov Report

Merging #5388 into master will decrease coverage by 2.65%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #5388      +/-   ##
==========================================
- Coverage   85.79%   83.13%   -2.66%     
==========================================
  Files         165      166       +1     
  Lines        1605     4395    +2790     
  Branches      549     1262     +713     
==========================================
+ Hits         1377     3654    +2277     
- Misses        228      741     +513
Impacted Files Coverage Δ
components/upload/Upload.tsx 36.75% <42.85%> (-63.25%) ⬇️
components/modal/index.tsx 57.89% <0%> (-42.11%) ⬇️
components/carousel/index.tsx 61.76% <0%> (-38.24%) ⬇️
components/tag/index.tsx 70.21% <0%> (-29.79%) ⬇️
components/layout/Sider.tsx 70.42% <0%> (-29.58%) ⬇️
components/badge/ScrollNumber.tsx 59.42% <0%> (-28.08%) ⬇️
components/message/index.tsx 75% <0%> (-25%) ⬇️
components/calendar/index.tsx 75% <0%> (-25%) ⬇️
components/popconfirm/index.tsx 75.55% <0%> (-24.45%) ⬇️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6f747...0eed044. Read the comment docs.

@benjycui
Copy link
Contributor

I cannot find a solution to solve TypeScript warning while using injectLocale with Upload.

Just use context for these cases #5103 (comment)

@afc163
Copy link
Member

afc163 commented Mar 20, 2017

What TypeScript warning?

@benjycui
Copy link
Contributor

[ts] Property 'Dragger' does not exist on type 'ComponentClass<UploadProps>'.

@benjycui benjycui merged commit c2cb111 into ant-design:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants