Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat spin wrapper className. #5425

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Feat spin wrapper className. #5425

merged 1 commit into from
Mar 21, 2017

Conversation

aaronplanell
Copy link
Contributor

Hello,

Add a div wrapper to the Animation component of the Spin. This div has a property className that can be setted in the Spin component.

Take a look to the previous rejected pull requests #5315 & #5318 for more information ( @afc163, @osala-netquest & @benjycui ).

Best regards.

@mention-bot
Copy link

@aaronplanell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @RaoHai, @afc163 and @benjycui to be potential reviewers.

@codecov
Copy link

codecov bot commented Mar 21, 2017

Codecov Report

Merging #5425 into feature-2.9 will increase coverage by 3.37%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           feature-2.9    #5425      +/-   ##
===============================================
+ Coverage        82.61%   85.99%   +3.37%     
===============================================
  Files              166      166              
  Lines             4401     4404       +3     
  Branches          1277     1278       +1     
===============================================
+ Hits              3636     3787     +151     
+ Misses             765      617     -148
Impacted Files Coverage Δ
components/spin/index.tsx 87.27% <100%> (+4.58%) ⬆️
components/table/Table.tsx 94.15% <0%> (+0.89%) ⬆️
components/tooltip/index.tsx 93.97% <0%> (+1.2%) ⬆️
components/table/SelectionCheckboxAll.tsx 93.42% <0%> (+1.31%) ⬆️
components/transfer/index.tsx 89.92% <0%> (+1.55%) ⬆️
components/menu/index.tsx 90.62% <0%> (+1.56%) ⬆️
components/tabs/index.tsx 95% <0%> (+1.66%) ⬆️
components/anchor/index.tsx 90.9% <0%> (+1.81%) ⬆️
components/radio/group.tsx 90.56% <0%> (+1.88%) ⬆️
components/alert/index.tsx 83.01% <0%> (+1.88%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d348ec...564d903. Read the comment docs.

@aaronplanell
Copy link
Contributor Author

Hi @afc163 & @benjycui !

I think that this time we have achieve the goal of the PR 😆
And only with three PRs, hehehe.

Best regards!

@afc163 afc163 merged commit 45b0693 into ant-design:feature-2.9 Mar 21, 2017
@afc163
Copy link
Member

afc163 commented Mar 21, 2017

😅

@aaronplanell
Copy link
Contributor Author

Thanks for your patience @afc163 & @benjycui !!!

@aaronplanell
Copy link
Contributor Author

aaronplanell commented Mar 31, 2017

Hello @afc163 & @benjycui !!!

I think you forget add this new feature in the documentation of the release 2.8.3:

Best regards!

@afc163
Copy link
Member

afc163 commented Mar 31, 2017

It is a feature at 2.9

@aaronplanell
Copy link
Contributor Author

aaronplanell commented Mar 31, 2017

Ooops! Well, I think is currently released. At least you can find the improvement in master:
https://github.com/ant-design/ant-design/tree/master/components/spin

😮

@afc163
Copy link
Member

afc163 commented Mar 31, 2017

Not published yet.

@aaronplanell aaronplanell deleted the feature-2.9 branch March 31, 2017 12:57
@aaronplanell
Copy link
Contributor Author

Perfect! I thought that how the improvement was released in the master branch the feature was now enabled.

@aaronplanell
Copy link
Contributor Author

In fact,... I don't see the branch ant-design:feature-2.9 😨 .
Are you sure that you don't have made the merge with master actually?

@afc163
Copy link
Member

afc163 commented Mar 31, 2017

Yes, it is going to be published soon, at there couple of days.

@afc163
Copy link
Member

afc163 commented Mar 31, 2017

You should check the released tag for released features: https://github.com/ant-design/ant-design/tree/2.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants