Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Select component notFoundContent locale. #5661

Merged
merged 2 commits into from
Apr 7, 2017

Conversation

life88
Copy link
Contributor

@life88 life88 commented Apr 7, 2017

Close: #5648

@mention-bot
Copy link

@LeeHarlan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @afc163 and @waywardmonkeys to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 7, 2017

Codecov Report

Merging #5661 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5661      +/-   ##
==========================================
+ Coverage   86.76%   86.79%   +0.02%     
==========================================
  Files         183      183              
  Lines        4512     4513       +1     
  Branches     1308     1308              
==========================================
+ Hits         3915     3917       +2     
+ Misses        597      596       -1
Impacted Files Coverage Δ
components/select/index.tsx 100% <ø> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93dd1e...da4c768. Read the comment docs.

@@ -97,7 +101,7 @@ export default class Select extends React.Component<SelectProps, any> {
return antLocale.Select;
}
return {
notFoundContent: 'Not Found',
notFoundContent: '暂无数据',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用“无匹配结果”更好点。

Copy link
Contributor Author

@life88 life88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

将“暂无数据”修改为"无匹配结果"

@yesmeck yesmeck merged commit d8ebd39 into ant-design:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants