not aligned after customizing the size of input #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reasons I customized the size of <Input/>. Now the default height of <Input> is 40px. But there's a problem in <RangePicker/> after doing that: the texts and icon inside it are not aligned vertically at center. When I look into the code I found the height of `ant-calendar-range-picker-input` is 18px. I modified it to 100% and it aligned. I'm not sure if it can affect the other code. ---------------------------------------- 因为某些原因我自定义了 <Input/> 的尺寸，现在它的默认高度是40px。但是当我使用 <RangePicker/> 组件时，我发现了一个问题：输入框里面的文字和图标在垂直方向不能居中对齐。我看了一下 css 代码，发现里面的 `ant-calendar-range-picker-input` 高度是固定的18px，我把它改成100%就可以垂直居中对齐了。我不知道这个改动是否会影响其他代码。
Codecov Report
@@ Coverage Diff @@
## master #5718 +/- ##
======================================
Coverage 86.7% 86.7%
======================================
Files 183 183
Lines 4513 4513
Branches 1308 1308
======================================
Hits 3913 3913
Misses 600 600Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reasons I customized the size of . Now the default height of is 40px. But there's a problem in after doing that: the texts and icon inside it are not aligned vertically at center.
When I look into the code I found the height of
ant-calendar-range-picker-inputis 18px. I modified it to 100% and it aligned. I'm not sure if it can affect the other code.因为某些原因我自定义了 的尺寸，现在它的默认高度是40px。但是当我使用 组件时，我发现了一个问题：输入框里面的文字和图标在垂直方向不能居中对齐。我看了一下 css 代码，发现里面的
ant-calendar-range-picker-input高度是固定的18px，我把它改成100%就可以垂直居中对齐了。我不知道这个改动是否会影响其他代码。First of all, thanks for your contribution! :-)
Please makes sure these boxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.