use PropTypes from 'prop-types' mdoule instead of React #5723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as React.PropTypes is being deprecated - Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead. - Solution: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes
|
@manjitkumar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @benjycui and @yesmeck to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #5723 +/- ##
==========================================
+ Coverage 86.7% 86.74% +0.04%
==========================================
Files 183 183
Lines 4513 4527 +14
Branches 1308 1308
==========================================
+ Hits 3913 3927 +14
Misses 600 600
Continue to review full report at Codecov.
|
|
ref #5678 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your contribution! :-)
Please makes sure these boxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x. (I am not sure about this, please help me raise this PR against correct branch)npm run lintand fix those errors before submitting in order to keep consistent code style.