Allow styling of radio button backgrounds #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi, build failure isn't from this change. Master is currently failing (https://travis-ci.org/ant-design/ant-design/builds/222804823) |
|
Rebase, please. |
Codecov Report
@@ Coverage Diff @@
## master #5791 +/- ##
==========================================
- Coverage 86.83% 86.81% -0.03%
==========================================
Files 183 183
Lines 4557 4557
Branches 1320 1318 -2
==========================================
- Hits 3957 3956 -1
- Misses 600 601 +1
Continue to review full report at Codecov.
|
|
done |
afc163
reviewed
Apr 20, 2017
components/style/themes/default.less
Outdated
| @@ -130,6 +130,10 @@ | |||
|
|
|||
| @btn-group-border : @primary-7; | |||
|
|
|||
| // Radio buttons | |||
| @btn-radio-bg : @btn-default-bg; | |||
| @btn-radio-color : @btn-default-color; | |||
There was a problem hiding this comment.
radio-button-bg radio-button-color
|
Done |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes radio buttons to use
@btn-default-bgas the background by default instead of@component-bg. This was causing issues with our theme as radio buttons were using@btn-default-colorwhich was not compatible with our default@component-bg.This also adds 2 variables which correspond to the
@btn-default-*settings by default@btn-radio-bg@btn-radio-color