new style of danger button #5815
Conversation
ddcat1115
commented
Apr 19, 2017
ddcat1115
commented
|
@ddcat1115, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @simaQ and @benjycui to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #5815 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 183 183
Lines 4560 4560
Branches 1323 1323
=======================================
Hits 3959 3959
Misses 601 601Continue to review full report at Codecov.
|
components/style/themes/default.less
Outdated
| @btn-danger-bg : @background-color-base; | ||
| @btn-danger-border : @border-color-base; | ||
| @btn-danger-hover-color: #fff; | ||
| @btn-danger-active-bg : @red-7; |
ddcat1115
force-pushed
the
danger-button
branch
from
d032d92
to
2b0109b
Compare
components/style/themes/default.less
Outdated
| @@ -108,8 +108,9 @@ | |||
| @btn-default-bg : #fff; | |||
| @btn-default-border : @border-color-base; | |||
|
|
|||
| @btn-danger-color : #fff; | |||
| @btn-danger-bg : @red-6; | |||
| @btn-danger-color : @red-6; | |||
There was a problem hiding this comment.
I've a suggestion here (Which I would've raised as a separate PR if I hadn't seen this one).
Can you assign this variable to @error-color?
https://github.com/ant-design/ant-design/blob/master/components/style/themes/default.less#L17
That way you only need to override error-color to get the desired color on the danger button.
Makes sense? @afc163 @benjycui
ddcat1115
force-pushed
the
danger-button
branch
from
c01227a
to
c9a404d
Compare
ddcat1115
force-pushed
the
danger-button
branch
from
c9a404d
to
d4875f2
Compare
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
