Add a less variable to opt out of form item colons #5855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5855 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 183 183
Lines 4560 4560
Branches 1323 1323
=======================================
Hits 3959 3959
Misses 601 601Continue to review full report at Codecov.
|
BANG88
reviewed
Apr 21, 2017
components/style/themes/default.less
Outdated
| @@ -194,6 +194,7 @@ | |||
| @label-required-color : @highlight-color; | |||
| @label-color : @text-color; | |||
| @form-item-margin-bottom : 24px; | |||
| @form-item-trailing-colon : false; | |||
There was a problem hiding this comment.
I think this should default to true ?
There was a problem hiding this comment.
Whoops thanks, didnt mean to commit it as false
megawac
force-pushed
the
optional-form-colon
branch
from
c35443c
to
297412b
Compare
|
I also remove colons |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colons disabled (@form-item-trailing-colon: false):
Colons enabled (@form-item-trailing-colon: true):
Our designer wanted to opt out of manadatory colons here