Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5884 support inlineIndent property of Menu for TypeScript #5903

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

brookshi
Copy link
Contributor

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you propose PR to correct branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@mention-bot
Copy link

@brookshi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @benjycui and @waywardmonkeys to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 25, 2017

Codecov Report

Merging #5903 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5903   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files         183      183           
  Lines        4558     4558           
  Branches     1323     1323           
=======================================
  Hits         3957     3957           
  Misses        601      601
Impacted Files Coverage Δ
components/menu/index.tsx 95.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd05d8...b50d08c. Read the comment docs.

@benjycui
Copy link
Contributor

Close: #5884

@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants