feat: expose TimePicker[open], close: #5775 & #5829 #5913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjycui
commented
Apr 26, 2017
components/time-picker/demo/addon.md
Outdated
| onOpen={this.toggleOpenStatus} | ||
| onClose={this.toggleOpenStatus} | ||
| addon={() => ( | ||
| <Button size="small" type="primary" onClick={this.handleClose}> |
There was a problem hiding this comment.
Make this more React-like.
|
pending for react-component/collapse#67 |
afc163
approved these changes
Apr 26, 2017
|
ci broken |
afc163
reviewed
Apr 27, 2017
| @@ -25,6 +25,9 @@ import moment from 'moment'; | |||
| |---------------------|-----|-----|-------| | |||
| | defaultValue | to set default time | [moment](http://momentjs.com/) | - | | |||
| | value | to set time | [moment](http://momentjs.com/) | - | | |||
| | open | whether to popup panel | boolean | false | | |||
| | onOpen | a callback function which will be called while panel opening | ({ open: boolean }): void | 无 | | |||
| | onClose | a callback function which will be called while panel closing | ({ open: boolean }): void | 无 | | |||
benjycui
force-pushed
the
feat-time-picker
branch
from
d05ef1c
to
68b4d83
Compare
benjycui
force-pushed
the
feat-time-picker
branch
from
68b4d83
to
03dea50
Compare
|
Updated. |
afc163
reviewed
Apr 27, 2017
| @@ -25,6 +25,8 @@ import moment from 'moment'; | |||
| |---------------------|-----|-----|-------| | |||
| | defaultValue | to set default time | [moment](http://momentjs.com/) | - | | |||
| | value | to set time | [moment](http://momentjs.com/) | - | | |||
| | open | whether to popup panel | boolean | false | | |||
| | onOpenChange | a callback function which will be called while panel opening/closing | (status: boolean): void | 无 | | |||
afc163
reviewed
Apr 27, 2017
| format?: string; | ||
| onChange?: (time: moment.Moment, timeString: string) => void; | ||
| onOpenChange?: (status: boolean) => void; |
|
后两个细节，我合并后再改。 |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #5775 & #5829