Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnamese localization support #5927

Merged
merged 2 commits into from
Apr 27, 2017
Merged

Conversation

pnghai
Copy link
Contributor

@pnghai pnghai commented Apr 27, 2017

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you propose PR to correct branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@mention-bot
Copy link

@pnghai, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yesmeck, @afc163 and @RaoHai to be potential reviewers.

@benjycui
Copy link
Contributor

Oops...... you should not mix others' commits into your PR.

@pnghai pnghai changed the base branch from feature-2.10 to master April 27, 2017 07:35
@pnghai
Copy link
Contributor Author

pnghai commented Apr 27, 2017

@benjycui I'm very sorry. I'm confused. As I've already commit to master branch, should I change request to master branch? Or should I revert and work on feature 2.10 branch?

@afc163
Copy link
Member

afc163 commented Apr 27, 2017

You should checkout from and PR to feature-2.10.

@benjycui
Copy link
Contributor

It's fine to PR to master, for we will publish a minor version this week.

@benjycui benjycui closed this Apr 27, 2017
@benjycui benjycui reopened this Apr 27, 2017
@benjycui benjycui merged commit c6832d1 into ant-design:master Apr 27, 2017
@pnghai
Copy link
Contributor Author

pnghai commented Apr 27, 2017

@benjycui Thank you very much.

@lock
Copy link

lock bot commented May 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants