fix Notification getContainer config bug #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8eb84c640bb75c7e3b7c9c35b3105ca147888d54
|
@hardfist, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @zhujun24 and @ddcat1115 to be potential reviewers. |
|
fix issue #6036 |
Codecov Report
@@ Coverage Diff @@
## master #6099 +/- ##
==========================================
+ Coverage 83.55% 83.56% +0.01%
==========================================
Files 199 199
Lines 4689 4692 +3
Branches 1354 1355 +1
==========================================
+ Hits 3918 3921 +3
Misses 771 771
Continue to review full report at Codecov.
|
benjycui
reviewed
May 11, 2017
| return $container; | ||
| }, | ||
| }); | ||
| expect($container.querySelector('.ant-notification')).not.toBe(null); |
There was a problem hiding this comment.
I don't understand, I think you should open a new notification before expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I8eb84c640bb75c7e3b7c9c35b3105ca147888d54
First of all, thanks for your contribution! :-)
Please makes sure these boxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.