Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support controlled panels for DatePicker and RangePicker, close: #5190 #7049

Merged
merged 1 commit into from Aug 21, 2017

Conversation

benjycui
Copy link
Contributor

@benjycui benjycui commented Aug 1, 2017

Close: #5190

@afc163
Copy link
Member

afc163 commented Aug 1, 2017

这个直接发到 3.0 吧。2.13 的功能先攒着。

@benjycui
Copy link
Contributor Author

benjycui commented Aug 1, 2017

这个直接 3.0 吧。2.13 的功能先攒着。

可以理解为 2.13.0 后,2.x 就不再新增 feature 了?

@afc163
Copy link
Member

afc163 commented Aug 1, 2017

也不是,只是不主动新增 feature 了。难以保证业务没有无法回避的需求。

@codecov
Copy link

codecov bot commented Aug 1, 2017

Codecov Report

Merging #7049 into antd-3.0 will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##           antd-3.0    #7049      +/-   ##
============================================
+ Coverage      86.2%   86.22%   +0.01%     
============================================
  Files           246      246              
  Lines          5105     5109       +4     
  Branches       1466     1468       +2     
============================================
+ Hits           4401     4405       +4     
  Misses          704      704
Impacted Files Coverage Δ
components/date-picker/RangePicker.tsx 95% <ø> (+0.08%) ⬆️
components/date-picker/createPicker.tsx 85.96% <66.66%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59bcf7...740add0. Read the comment docs.

@coryisbest0728
Copy link

弱弱的问一句,这个功能什么时候能发版呀?

@benjycui
Copy link
Contributor Author

benjycui commented Aug 2, 2017

也不是,只是不主动新增 feature 了。

其实我倾向于尽可能的把 feature 放到 2.x ,3.0 只是做非兼容改动。

@benjycui
Copy link
Contributor Author

benjycui commented Aug 8, 2017

因为我们现在 rc 这层的版本问题。。 #7125 依赖于最新版的 rc-calendar,所以 rc-calendar 的版本必须升级,所以这个受控面板的功能还是会暴露。。

@afc163
Copy link
Member

afc163 commented Aug 8, 2017

把 sr_RS 的改动 cherry-pick 到 9.0.x 上发一个 patch。

@benjycui benjycui changed the base branch from feature-2.13 to antd-3.0 August 14, 2017 02:16
@benjycui
Copy link
Contributor Author

@afc163 done

@afc163 afc163 merged commit 2620318 into antd-3.0 Aug 21, 2017
@afc163 afc163 deleted the feat-datepicker branch August 21, 2017 13:15
@afc163
Copy link
Member

afc163 commented Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants