Skip to content

Commit

Permalink
fix: aliased import bug. close #106
Browse files Browse the repository at this point in the history
  • Loading branch information
paranoidjk committed May 30, 2017
1 parent d24be12 commit 90a45e1
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 8 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ tmp
node_modules
coverage
lib

*.log
*.log.*
2 changes: 1 addition & 1 deletion src/Plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default class Plugin {
props.forEach(prop => {
if (!types.isIdentifier(node[prop])) return;
if (this.specified[node[prop].name]) {
node[prop] = this.importMethod(node[prop].name, file); // eslint-disable-line
node[prop] = this.importMethod(this.specified[node[prop].name], file); // eslint-disable-line
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export default function ({ types }) {
};

for (const method of methods) {
ret.visitor[method] = function () {
ret.visitor[method] = function () { // eslint-disable-line
applyInstance(method, arguments, ret.visitor); // eslint-disable-line
};
}
Expand Down
5 changes: 5 additions & 0 deletions test/fixtures/import-alias/actual.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { Select as AntdSelect } from 'antd';

if (AntdSelect) {
console.log('foo');
}
11 changes: 11 additions & 0 deletions test/fixtures/import-alias/expected.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'use strict';

var _select = require('antd/lib/select');

var _select2 = _interopRequireDefault(_select);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

if (_select2.default) {
console.log('foo');
}
10 changes: 5 additions & 5 deletions test/fixtures/multiple-libraries/expected.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
'use strict';

var _selectMobile = require('antd-mobile/lib/select-mobile');
var _select = require('antd-mobile/lib/select');

var _selectMobile2 = _interopRequireDefault(_selectMobile);
var _select2 = _interopRequireDefault(_select);

var _select = require('antd/lib/select');
var _select3 = require('antd/lib/select');

var _select2 = _interopRequireDefault(_select);
var _select4 = _interopRequireDefault(_select3);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

if (_select4.default) {}
if (_select2.default) {}
if (_selectMobile2.default) {}

0 comments on commit 90a45e1

Please sign in to comment.