Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ feat(form): optimize query filter performance #1074

Merged
merged 8 commits into from Nov 24, 2020
Merged

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Nov 24, 2020

close #1055

@github-actions
Copy link

github-actions bot commented Nov 24, 2020

🎊 PR Preview 97d1676 has been successfully built and deployed to https://ant-design-pro-components-preview-pr-1074.surge.sh

🕐 Build time: 521.295s

🤖 By surge-preview

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 8e78ce0 into 4a25cf2 - view on LGTM.com

new alerts:

  • 1 for Useless comparison test

fixed alerts:

  • 1 for Useless conditional

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1074 (97d1676) into master (4a25cf2) will increase coverage by 0.11%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   96.14%   96.25%   +0.11%     
==========================================
  Files         143      143              
  Lines        3787     3795       +8     
  Branches     1385     1388       +3     
==========================================
+ Hits         3641     3653      +12     
+ Misses        141      138       -3     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
packages/field/src/index.tsx 100.00% <ø> (ø)
...ckages/utils/src/components/LabelIconTip/index.tsx 100.00% <ø> (ø)
packages/table/src/Form/index.tsx 95.97% <93.02%> (+0.08%) ⬆️
packages/form/src/layouts/QueryFilter/index.tsx 97.53% <96.92%> (+4.19%) ⬆️
packages/form/src/BaseForm/index.tsx 100.00% <100.00%> (ø)
packages/table/src/Table.tsx 96.25% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a25cf2...97d1676. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Nov 24, 2020

size-limit report

Path Size
packages/card/dist/card.js, packages/card/dist/card.min.js 186.49 KB (+0.01% 🔺)
packages/descriptions/dist/descriptions.js, packages/descriptions/dist/descriptions.min.js 543.51 KB (+0.01% 🔺)
packages/field/dist/field.js, packages/field/dist/field.min.js 176.51 KB (0%)
packages/form/dist/form.js, packages/form/dist/form.min.js 506.9 KB (+0.08% 🔺)
packages/layout/dist/layout.js, packages/layout/dist/layout.min.js 278.66 KB (0%)
packages/list/dist/list.js, packages/list/dist/list.min.js 950.61 KB (+0.04% 🔺)
packages/provider/dist/provider.js, packages/provider/dist/provider.min.js 13.45 KB (0%)
packages/skeleton/dist/skeleton.js, packages/skeleton/dist/skeleton.min.js 23.51 KB (0%)
packages/table/dist/table.js, packages/table/dist/table.min.js 655.07 KB (+0.04% 🔺)

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 348d1e4 into 4a25cf2 - view on LGTM.com

new alerts:

  • 1 for Useless comparison test

fixed alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 24, 2020

This pull request fixes 1 alert when merging bcdd861 into 4a25cf2 - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 24, 2020

This pull request fixes 1 alert when merging bca773f into 4a25cf2 - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 24, 2020

This pull request fixes 1 alert when merging 550c27e into 4a25cf2 - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 24, 2020

This pull request introduces 1 alert and fixes 1 when merging 0a691ee into 4a25cf2 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

fixed alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 24, 2020

This pull request fixes 1 alert when merging 97d1676 into 4a25cf2 - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional

@chenshuai2144 chenshuai2144 merged commit 38f7af3 into master Nov 24, 2020
@chenshuai2144 chenshuai2144 deleted the re-render branch November 24, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[BUG]关于搜索表单重复请求
1 participant