Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update listenerHookURL parameter with Update broadcast process #3948

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Update listenerHookURL parameter with Update broadcast process #3948

merged 4 commits into from
Feb 4, 2022

Conversation

SelimEmre
Copy link
Contributor

@SelimEmre SelimEmre requested a review from mekya February 3, 2022 23:33
mekya
mekya approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added isEmpty check. This kind of thing make life easier for users. So the life will be easier for us as well.

@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@mekya mekya merged commit 1f6629e into master Feb 4, 2022
@mekya mekya deleted the fix/issue-3893 branch February 4, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SelimEmre @mekya