Fix mongodb compatibility - #add-release-notes #4114
Conversation
feature/mongodb-backward-compatible
There was a problem hiding this comment.
Thank you for your work.
Please take a look at the comments.
In addition, it would be better if it supported mongodb atlas. I mean support for mongodb:// and mongodb+srv://
@muratugureminoglu @SelimEmre
I'm confirming this PR because no need to be perfect and we'll need to release a new version soon.
|
|
||
|
|
||
| mongocon() { | ||
| if [ -z "$MONGODB_USERNAME" ] && [ -z "$MONGODB_PASSWORD" ]; then |
There was a problem hiding this comment.
Handling username and password is good. It would be better if there is single command instead of having 'run_mongo' and 'run_mongo_auth'. It decrease the code duplication
| mongo --host $MONGODB_IP --authenticationDatabase admin $db --quiet --username $MONGODB_USERNAME --password $MONGODB_PASSWORD --eval "$@" | ||
| } | ||
|
|
||
| mongo_backup(){ |
| echo "The backup is not completed so it does not continue." | ||
| echo "Please check credentials are correct and you've write permission to current directory: `pwd` " | ||
| echo "If it's a permission issue, you may need to run this command with sudo" | ||
| exit 1; |
There was a problem hiding this comment.
I've added this case. If backup is not successful, let's stop the process. Don't get risk.
| run_mongo_auth() { | ||
| db=$1 | ||
| shift | ||
| mongo --host $MONGODB_IP --authenticationDatabase admin $db --quiet --username $MONGODB_USERNAME --password $MONGODB_PASSWORD --eval "$@" |
There was a problem hiding this comment.
mongo is deprecated. Let's start to use mongosh
| } | ||
|
|
||
| #check if mongodb IP address is set | ||
| if [ -z "$MONGODB_IP" ]; then |
| fi | ||
|
|
||
| #check if mongodb client tools is available | ||
| if ! [ -x "$(command -v mongo)" ]; then |
|
Kudos, SonarCloud Quality Gate passed!
|
mekya
changed the title
#4027