Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get camera profiles #4289

Merged
merged 8 commits into from
Aug 12, 2022
Merged

Get camera profiles #4289

merged 8 commits into from
Aug 12, 2022

Conversation

burak-58
Copy link
Contributor

Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the comments

@@ -827,6 +827,16 @@ public Result stopStreamingV2(@ApiParam(value = "the id of the broadcast.", requ
public String[] searchOnvifDevicesV2() {
return super.searchOnvifDevices();
}

@ApiOperation(value = "Get The Profile List for an ONVIF IP Cameras", notes = "Notes here", response = Result.class)
@POST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be GET method

src/main/java/io/antmedia/rest/BroadcastRestService.java Outdated Show resolved Hide resolved

@ApiOperation(value = "Get The Profile List for an ONVIF IP Cameras", notes = "Notes here", response = Result.class)
@POST
@Path("/onvif-device-profiles")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the url in this format
/{id}/ip-camera/device-profiles

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

85.2% 85.2% Coverage
0.0% 0.0% Duplication

@mekya mekya merged commit e420484 into master Aug 12, 2022
@mekya mekya deleted the getCameraProfiles branch August 12, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants