Add TURN server parameters to start.sh script #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muratugureminoglu
force-pushed
the
add_turn_server_parameters
branch
from
bd47df7
to
0643027
Compare
mekya
approved these changes
Oct 5, 2022
mekya
requested changes
Oct 10, 2022
src/main/server/start.sh
Outdated
| # Turn server configuration. | ||
| if [ ! -z "${TURN_URL}" ] || [ ! -z "${TURN_USERNAME}" ] || [ ! -z ${TURN_PASSWORD} ]; then | ||
| for applist in $LIST_APPS; do | ||
| echo -e "settings.webrtc.stunServerURI=turn:${TURN_URL}\nsettings.webrtc.turnServerUsername=${TURN_USERNAME}\n |
There was a problem hiding this comment.
No need to force "turn:", it can be stun server as well.
src/main/server/start.sh
Outdated
| @@ -15,6 +15,12 @@ | |||
| # -u: MongoDB username: Deprecated. Just give the username in the connection string with -h parameter | |||
| # | |||
| # -p: MongoDB password: Deprecated. Just give the password in the connection string with -h parameter | |||
| # | |||
| # -a: TURN Server URL | |||
There was a problem hiding this comment.
Please give the url format simply. I think it should start with turn: or stun:
|
Kudos, SonarCloud Quality Gate passed!
|
mekya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.