Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added liveness endpoint using JSON body #4504

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

ducminhgd
Copy link
Contributor

This endpoint is used for checking liveness if using K8s with HTTP type healthcheck.

Response hostname for knowing which pod is OK

@ducminhgd
Copy link
Contributor Author

Hello @burak-58 ,

Sorry for tagging you. Does Travis CI Build Job of this pull request need shared key from base repository? Here is log from the job

$ openssl aes-256-cbc -K $encrypted_5fef4fa28306_key -iv $encrypted_5fef4fa28306_iv -in codesigning.asc.enc -out codesigning.asc -d
iv undefined
The command "openssl aes-256-cbc -K $encrypted_5fef4fa28306_key -iv $encrypted_5fef4fa28306_iv -in codesigning.asc.enc -out codesigning.asc -d" failed and exited with 1 during .

@mekya
Copy link
Contributor

mekya commented Oct 25, 2022

Hi @ducminhgd,

Thank you for the PR. I really appreciate your effort here. I'm likely going to merge it today.

Travis issue is more about the security in travis side because PR is coming from another repo outside of the organization.

Btw, are you open to join community hours?
https://community.antmedia.io/topic/1414-%F0%9F%93%A3-weekly-qa-meeting-about-anything-you-want-%F0%9F%98%8D-every-thursday/

Shall we get connected with you on linkedin or somewhere to chat with you?

@mekya mekya merged commit d230dbf into ant-media:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants