Checks subtrack and maintrack in addSubtrack REST method #4953

mekya · 2023-03-31T00:31:15Z

No description provided.

sonatype-lift · 2023-03-31T00:46:39Z

src/main/java/io/antmedia/datastore/db/InMemoryDataStore.java

+			}
+			subTracks.add(subTrackId);
+			mainTrack.setSubTrackStreamIds(subTracks);
+			broadcastMap.put(mainTrackId, mainTrack);


THREAD_SAFETY_VIOLATION: Unprotected write. Non-private method InMemoryDataStore.addSubTrack(...) mutates container this.broadcastMap via call to Map.put(...) outside of synchronization.
Reporting because another access to the same memory occurs on a background thread, although this access may not.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-31T00:46:40Z

src/main/java/io/antmedia/rest/BroadcastRestService.java

+		}
+		else {
+			result.setMessage("There is not stream with id:" + subTrackId);
+			logger.warn("There is not stream with id:{}" , subTrackId);


CRLF_INJECTION_LOGS: This use of org/slf4j/Logger.warn(Ljava/lang/String;Ljava/lang/Object;)V might be used to include CRLF characters into log messages

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/main/java/io/antmedia/rest/BroadcastRestService.java 983

src/main/java/io/antmedia/rest/BroadcastRestService.java 988

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-31T13:18:47Z

src/main/java/org/red5/server/net/rtmp/RTMPHandler.java

+		// get the method name
+		final String action = call.getServiceMethodName();
+		// If it's a callback for server remote call then pass it over to callbacks handler and return
+		if ("_result".equals(action) || "_error".equals(action)) {


YodaCondition: The non-constant portion of an equals check generally comes first.

Suggested change

if ("_result".equals(action) || "_error".equals(action)) {

if (Objects.equals(action, "_result") || "_error".equals(action)) {

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-31T13:18:49Z

src/main/java/org/red5/server/net/rtmp/RTMPHandler.java

+		// get the method name
+		final String action = call.getServiceMethodName();
+		// If it's a callback for server remote call then pass it over to callbacks handler and return
+		if ("_result".equals(action) || "_error".equals(action)) {


YodaCondition: The non-constant portion of an equals check generally comes first.

Suggested change

if ("_result".equals(action) || "_error".equals(action)) {

if ("_result".equals(action) || Objects.equals(action, "_error")) {

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-31T13:18:51Z

src/main/java/org/red5/server/net/rtmp/RTMPHandler.java

+				disconnectOnReturn = true;
+			}
+			// Evaluate request for AMF3 encoding
+			if (new Double(3d).equals(params.get("objectEncoding"))) {


BoxedPrimitiveConstructor: valueOf or autoboxing provides better time and space performance

Suggested change

if (new Double(3d).equals(params.get("objectEncoding"))) {

if (Double.valueOf(3d).equals(params.get("objectEncoding"))) {

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-31T13:18:53Z

src/main/java/org/red5/server/net/rtmp/RTMPHandler.java

+	}
+
+	/**
+	 * @param dispatchStreamActions


MissingSummary: A summary line is required on public/protected Javadocs.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-31T13:18:55Z

src/main/java/org/red5/server/net/rtmp/RTMPHandler.java

+	}
+
+	/**
+	 * @return the dispatchStreamActions


MissingSummary: A summary fragment is required; consider using the value of the @return block as a summary fragment instead.

Suggested change

* @return the dispatchStreamActions

*Returns the dispatchStreamActions.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignoreall

The ignoreall command is active on this PR, all the existing Lift issues are ignored.

sonatype-lift · 2023-03-31T13:18:58Z

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.¹

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ant-media/Ant-Media-Server/4953.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/ant-media/Ant-Media-Server/4953.diff | git apply

Once you're satisfied, commit and push your changes in your project.

You can preview the patch by opening the patch URL in the browser. ↩

sonarcloud · 2023-03-31T16:49:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

84.6% Coverage
0.8% Duplication

Checks subtrack and maintrack in addSubtrack REST method

3821d98

sonatype-lift bot reviewed Mar 31, 2023

View reviewed changes

mekya added 2 commits March 31, 2023 12:20

Add log and fix sonar issues

27da279

Increase code coverage

3b0da0c

sonatype-lift bot reviewed Mar 31, 2023

View reviewed changes

Increase code coverage

02dce64

mekya merged commit fea8ccc into master Apr 1, 2023
4 checks passed

mekya deleted the fix-room-info-command branch April 1, 2023 10:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checks subtrack and maintrack in addSubtrack REST method #4953

Checks subtrack and maintrack in addSubtrack REST method #4953

mekya commented Mar 31, 2023

sonatype-lift bot Mar 31, 2023

sonatype-lift bot Mar 31, 2023

sonatype-lift bot Mar 31, 2023

sonatype-lift bot Mar 31, 2023

sonatype-lift bot Mar 31, 2023

sonatype-lift bot Mar 31, 2023

sonatype-lift bot Mar 31, 2023

mekya Apr 1, 2023

sonatype-lift bot Apr 1, 2023

sonatype-lift bot commented Mar 31, 2023

sonarcloud bot commented Mar 31, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

	if ("_result".equals(action) \|\| "_error".equals(action)) {
	if (Objects.equals(action, "_result") \|\| "_error".equals(action)) {

	if ("_result".equals(action) \|\| "_error".equals(action)) {
	if ("_result".equals(action) \|\| Objects.equals(action, "_error")) {

	if (new Double(3d).equals(params.get("objectEncoding"))) {
	if (Double.valueOf(3d).equals(params.get("objectEncoding"))) {

	* @return the dispatchStreamActions
	*Returns the dispatchStreamActions.

Checks subtrack and maintrack in addSubtrack REST method #4953

Checks subtrack and maintrack in addSubtrack REST method #4953

Conversation

mekya commented Mar 31, 2023

sonatype-lift bot Mar 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 31, 2023

Choose a reason for hiding this comment

mekya Apr 1, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 1, 2023

Choose a reason for hiding this comment

sonatype-lift bot commented Mar 31, 2023

🛠 Lift Auto-fix

Footnotes

sonarcloud bot commented Mar 31, 2023