Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata field on updateStreamInfo function #4976

Merged
merged 2 commits into from Apr 10, 2023
Merged

Update metadata field on updateStreamInfo function #4976

merged 2 commits into from Apr 10, 2023

Conversation

mustafaboleken
Copy link
Contributor

@mustafaboleken mustafaboleken linked an issue Apr 5, 2023 that may be closed by this pull request
When updating broadcast object, metadata field is not updated #4975
Closed
@mustafaboleken mustafaboleken changed the title Update DataStore.java updating metadata field on updateStreamInfo function Apr 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mekya mekya changed the title updating metadata field on updateStreamInfo function Update metadata field on updateStreamInfo function Apr 10, 2023
mekya
mekya approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the test code @mustafaboleken

@mekya mekya merged commit 8ebd3d0 into master Apr 10, 2023
4 checks passed
@mekya mekya deleted the fix/issue-4975 branch April 10, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When updating broadcast object, metadata field is not updated
2 participants
@mustafaboleken @mekya