Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable JVM memory options #5342

Merged
merged 15 commits into from Feb 23, 2024
Merged

Add configurable JVM memory options #5342

merged 15 commits into from Feb 23, 2024

Conversation

muratugureminoglu
Copy link
Contributor

@muratugureminoglu muratugureminoglu commented Jul 7, 2023 •
edited by mekya

sonatype-lift[bot]
sonatype-lift bot reviewed Jul 7, 2023
View reviewed changes
src/main/server/start.sh Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mekya
Copy link
Contributor

mekya commented Jul 10, 2023

It's not passing the CI. Could you please check or restart @muratugureminoglu ?

@muratugureminoglu
Copy link
Contributor Author

Hi @mekya

The build process was successful after triggering it. Furthermore, I believe Sonatype has identified a false positive.Fyi.

mekya
mekya requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just having a question

src/main/server/start.sh Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@muratugureminoglu muratugureminoglu mentioned this pull request Nov 30, 2023
Closed
mekya
mekya requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @muratugureminoglu ,
Thank you for your PR.

I'm asking some changes to make the code clean.

Secondly, please make sure that CI is passing and it's ready to merge. Check that Travis has failed for Branch. It may be related to this PR or not. Alternatively, re-trying may it pass if it's temporary issue.

Regards

src/main/server/start.sh Outdated Show resolved Hide resolved
src/main/server/start.sh Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mekya mekya merged commit d9edd2a into master Feb 23, 2024
0 of 2 checks passed
@mekya mekya deleted the feature/jvm-memory-options branch February 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

@mekya mekya mekya approved these changes

@mustafaboleken mustafaboleken mustafaboleken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@muratugureminoglu @mekya @mustafaboleken