Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support authorization code grant without client_secret #5

Closed
rowanbarrie opened this issue Dec 6, 2021 · 0 comments · Fixed by #7
Closed

Support authorization code grant without client_secret #5

rowanbarrie opened this issue Dec 6, 2021 · 0 comments · Fixed by #7

Comments

@rowanbarrie
Copy link

Hi Benjamin,

This library looks super useful, especially for the handling of the loopback redirect server!

Currently though omitting the client_secret in the ServiceInformation constructor results in the following error:

TypeError: __init__() missing 1 required positional argument: 'client_secret'

As I understand it the client_secret is not applicable in the case of a public client/application because they cannot hold credentials securely.

I may be missing something here, but it would be great if there were support for the authorization code grant without the client_secret.

Also +1 for Authorization Code Grant Flow with PKCE support!

Thanks
timgates42 added a commit to iress/OAuth2Client that referenced this issue Sep 3, 2022
@timgates42
Authorization code grant without client_secret
c9af782 
Addresses issue antechrestos#5 which seems to be the only missing piece to get PKCE
authentication working with Okta PKCE auth for a native application
deployment.
@timgates42 timgates42 mentioned this issue Sep 3, 2022
Merged
timgates42 added a commit to iress/OAuth2Client that referenced this issue Sep 3, 2022
@timgates42
Authorization code grant without client_secret
f81cabc 
Addresses issue antechrestos#5 which seems to be the only missing piece to get PKCE
authentication working with Okta PKCE auth for a native application
deployment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Authorization code grant without client_secret iress/OAuth2Client
1 participant
@rowanbarrie