Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization code grant without client_secret #7

Merged

Conversation

timgates42
Copy link
Contributor

@timgates42 timgates42 commented Sep 3, 2022

Addresses issue #5 which seems to be the only missing piece to get PKCE
authentication working with Okta PKCE auth for a native application
deployment.

Closes #5

Addresses issue antechrestos#5 which seems to be the only missing piece to get PKCE
authentication working with Okta PKCE auth for a native application
deployment.
@timgates42 timgates42 force-pushed the feature/pkce_authorization_header branch 2 times, most recently from 6293c0c to f81cabc Compare September 3, 2022 02:31
@antechrestos antechrestos merged commit b6f8f9f into antechrestos:master Sep 3, 2022
@antechrestos
Copy link
Owner

@timgates42 We met issue with the implementation of public oauth api with cloudfoundry client: this late one defaultly set client id to cf and client secret to ""

Deducing public api with if self.client_secret only (without distinction of "" and None) makes it fail.

I mae some change in #15 to make the distinction. That will be releeased in 1.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support authorization code grant without client_secret
2 participants