Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tsup build esm import ReleaseType error #22

Merged
merged 1 commit into from Jan 17, 2024

Conversation

dockfries
Copy link

@dockfries dockfries commented Nov 23, 2023

Description

This PR contains two fixes.

One is the extra ts type ReleaseType in the build,
and the other is that when tsup is packing, it encounters picocolors to generate esm and builds an invalid __require.
Dynamic require of "tty" is not supported

Linked Issues

fixes #9

Additional context

referenced from 为什么是 tsup and discussion Make require work in ESM bundle

@dockfries dockfries marked this pull request as ready for review November 23, 2023 10:40
@tjx666
Copy link

tjx666 commented Jan 17, 2024

@antfu very need this to make bumpp works in esm context

@antfu antfu merged commit 615001b into antfu-collective:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run versionBumpp function in a mjs file
3 participants