Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: version update in package-lock.json #26

Merged
merged 1 commit into from Jan 22, 2024

Conversation

Sec-ant
Copy link

@Sec-ant Sec-ant commented Jan 22, 2024

Description

should also update packages[""].version in package-lock.json.

Linked Issues

Additional context

https://docs.npmjs.com/cli/v10/configuring-npm/package-lock-json#packages

@antfu
Copy link
Member

antfu commented Jan 22, 2024

I am not so sure. I honestly think they shouldn't put the version in the lock - but anyway, isn't that you are supposed to run npm i after bumping the versions - in which you should have the lock updated as well?

@Sec-ant
Copy link
Author

Sec-ant commented Jan 22, 2024

isn't that you are supposed to run npm i after bumping the versions

I've been doing exactly this before I decided to use this tool.

npm i will update these two values together. bumpp already bumps the version field in package-lock.json, I see no reason to exclude packages[""].version?

And the default behavior of bumpp doesn't give me an opportunity to run npm i before I commit and push. I love the default commit message and tags so this packages[""].version thing is the only part that I need for a one-pass solution without further configuration.

@antfu antfu changed the title fix: version update in package-lock.json feat: version update in package-lock.json Jan 22, 2024
@antfu antfu merged commit ba39e94 into antfu-collective:main Jan 22, 2024
Sec-ant referenced this pull request in Sec-ant/prettier-plugin-embed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants