feat: intercept iconify api requests #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, let's see how it goes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds iconify api fetch interception to avoid make requests to iconify api server serving collections from local.
EDIT: icones is using prompt for update, this PR also updates it to use auto update, but we should use virtual module instead
registerSWscript (not included in the PR, ping me if you want to include it).Linked Issues
closes #135
Additional context
iconify-iconprovides also a way to disable local storage: I've included the required logic to disable it when using PWA:PWAtovite.defineto allow use local storage when running dev server without PWA (current behavior)