Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve scrolling and load-more issue in IconSetView when overflowed #168

Closed
wants to merge 2 commits into from

Conversation

Innei
Copy link
Contributor

@Innei Innei commented Jul 7, 2023

Description

In this Pull Request (PR), I've addressed a usability issue impacting the IconSetView within our application.

The primary change is:

IconSetView Overflow Fix: I've fixed an issue where users couldn't scroll through or load more icons in IconSet when it was overflowed. With this fix, users can now seamlessly browse and load more icons, even when the IconSetView is overflowing, thus improving the overall usability of our application.
As always, I appreciate your time in reviewing this fix and look forward to any feedback or suggestions for further improvements.

Linked Issues

Additional context

Innei added 2 commits July 7, 2023 22:36
Signed-off-by: Innei <i@innei.in>
Signed-off-by: Innei <i@innei.in>
@antfu antfu closed this in 6ae5141 Jul 7, 2023
@antfu
Copy link
Member

antfu commented Jul 7, 2023

Thanks. But I don't really like the footer being pinned. I tried another approach :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants