feat: rename nx to nix #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a conflict with the existing tool [nx](https://nx.dev/), a pretty popular tool, we find it better to rename `nx` to `nix` for compatibility. Everyone can still create an alias if they still want to use `nix` as `nx`.
5 tasks
cirocfc
reviewed
Feb 10, 2023
| @@ -1,3 +1,3 @@ | |||
| #!/usr/bin/env node | |||
| 'use strict' | |||
| import '../dist/nx.mjs' | |||
| import '../dist/nix.mjs' | |||
There was a problem hiding this comment.
Thank you @joaosamouco for the proposed changes.
The permissions on this file changed.
I don't know if this was intended, so just pointing it out.
There was a problem hiding this comment.
Thanks for pointing that out. I didn't notice it!
I just checked and all other files on bin have 755 so I think these are the correct permissions.
There was a problem hiding this comment.
So I think you don't need it to be 755 since npm changes it to 755 on install, but this will make it easier to test
Zeko369
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a conflict with the existing tool nx, a pretty popular tool, we find it better to rename
nxtonixfor compatibility.Everyone can still create an alias if they still want to use
nixasnx.Linked Issues
#118