Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always use github link #36

Merged
merged 1 commit into from Jan 12, 2023
Merged

fix: always use github link #36

merged 1 commit into from Jan 12, 2023

Conversation

kecrily
Copy link
Contributor

@kecrily kecrily commented Jan 12, 2023 •
edited

Description

Fix always use GitHub link

sponsor.linkUrl || sponsor.login ? `https://github.com/${sponsor.login}` : undefined

is

(sponsor.linkUrl || sponsor.login) ? `https://github.com/${sponsor.login}` : undefined

But we actually want

sponsor.linkUrl || (sponsor.login ? `https://github.com/${sponsor.login}` : undefined)

Linked Issues

Additional context

We can use no-mixed-operators to avoid this situation.

@kecrily kecrily mentioned this pull request Jan 12, 2023
Merged
@antfu antfu merged commit ad135a3 into antfu-collective:main Jan 12, 2023
@kecrily kecrily deleted the fix/logic branch January 12, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kecrily @antfu