Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store Math.random locally to prevent overriding it #8

Merged
merged 1 commit into from May 29, 2023

Conversation

AriPerkkio
Copy link
Contributor

Description

Store Math.random locally during module initialization. In Vitest if users mock Math.random and do not restore it correctly, Vitest will simply freeze and birpc timeouts.

Linked Issues

Additional context

I also checked all other public APIs and don't think there are any other APIs that need such handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants